using model_validator on GRLSettings. Allows null default values, then to asser them on load. Required so pydantic_settings can be loaded in tests without params

1 files changed, 7 insertions, 10 deletions

diff --git a/jb/flow/assignment_tasks.py b/jb/flow/assignment_tasks.py
index bdebb3d..b3c820a 100644
--- a/jb/flow/assignment_tasks.py
+++ b/jb/flow/assignment_tasks.py
@@ -1,5 +1,4 @@
-import logging
-
+from jb.decorators import LOG
 from jb.flow.monitoring import emit_assignment_event, emit_error_event
 from jb.managers.amt import (
     REJECT_MESSAGE_UNKNOWN_ASSIGNMENT,
@@ -27,7 +26,7 @@ def process_assignment_submitted(
     #
     # Step 1: Attempt to get the Assignment out of the API
     #
-    logging.info(f"{event=}")
+    LOG.info(f"{event=}")
 
     # This is the assignment model from AMT. In the DB, we should only have
     #   the AssignmentStub
@@ -42,7 +41,7 @@ def process_assignment_submitted(
         # It is not found in amt, either it is invalid, not yet submitted, or
         # already been approved/rejected, so we just do nothing ...
         # todo: maybe we confirm its state matches what we have in the db
-        logging.warning(f"No assignment found on AMT: {event.amt_assignment_id}")
+        LOG.warning(f"No assignment found on AMT: {event.amt_assignment_id}")
         emit_error_event(
             event_type="assignment_not_found_in_amt",
             amt_hit_type_id=event.amt_hit_type_id,
@@ -70,9 +69,7 @@ def review_hit(amtm: AMTManager, hm: HitManager, assignment: Assignment) -> None
     hit, _ = amtm.get_hit_if_exists(amt_hit_id=assignment.amt_hit_id)
 
     if hit is None:
-        logging.warning(
-            f"Hit not found when trying to review hit: {assignment.amt_hit_id}"
-        )
+        LOG.warning(f"Hit not found when trying to review hit: {assignment.amt_hit_id}")
         return
 
     # Update the db
@@ -101,7 +98,7 @@ def reject_assignment(
             event_type="failed_to_reject_assignment",
             amt_hit_type_id=amt_hit_type_id,
         )
-        logging.exception(f"Failed to reject assignment: {amt_assignment_id}")
+        LOG.exception(f"Failed to reject assignment: {amt_assignment_id}")
 
     # We just rejected this assignment, get it from amazon again
     assignment = amtm.get_assignment(amt_assignment_id=amt_assignment_id)
@@ -112,7 +109,7 @@ def reject_assignment(
     #   need to create as assignment first ...
     stub = am.get_stub_if_exists(amt_assignment_id=assignment.amt_assignment_id)
     if stub is None:
-        logging.warning(
+        LOG.warning(
             f"Rejected assignment doesn't exist in DB. Creating ... : {amt_assignment_id}"
         )
         # Even if the assignment doesn't exist, the hit must ...
@@ -123,5 +120,5 @@ def reject_assignment(
     emit_assignment_event(
         status=AssignmentStatus.Rejected, amt_hit_type_id=amt_hit_type_id, reason=msg
     )
-    logging.warning(f"Rejected assignment: {amt_assignment_id}")
+    LOG.warning(f"Rejected assignment: {amt_assignment_id}")
     return assignment